fix(spec): add GET drives/{drive-id}/items/{item-id}/children#43
Open
dschmidt wants to merge 1 commit into
Open
fix(spec): add GET drives/{drive-id}/items/{item-id}/children#43dschmidt wants to merge 1 commit into
dschmidt wants to merge 1 commit into
Conversation
The handler GetDriveItemChildren at services/graph/pkg/service/v0/driveitems.go:285 has existed for a while but was undocumented. Add the matching spec entry so generated clients expose a typed method for listing children of a non-root item. Mirrors the response shape of the existing HomeGetChildren operation (a Collection-of-driveItems object with value[] and an optional @odata.nextLink), and acknowledges the MS Graph colon-syntax URL forms the server accepts via path-lookup middleware.
dschmidt
changed the title
dschmidt
force-pushed
the
feat/list-children
branch
from
24f55f5 to
5222cb6
Compare
dschmidt
requested review from
butonic,
dragotin,
fschade,
kulmann,
micbar and
rhafer
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the spec entry for the existing
GET /v1.0/drives/{drive-id}/items/{item-id}/childrenendpoint, which has been implemented asGetDriveItemChildren(services/graph/pkg/service/v0/driveitems.go:285) but had no matching OpenAPI definition. Generated clients (libre-graph-api-go, -typescript-axios, etc.) will pick up a typed method for listing children of a non-root item.Response shape mirrors the existing
HomeGetChildrenoperation: a Collection-of-driveItems object withvalue[]and an optional@odata.nextLink.The description also acknowledges the MS Graph colon-syntax URL forms (
/root:/{path}:/childrenand/items/{item-id}:/{path}:/children) the server accepts via the path-lookup middleware - OpenAPI cannot express the colon-delimited path segment, so they aren't separate operations but are documented inline.It's not supported yet, but will be when opencloud-eu/opencloud#2688 is merged.
Changes in this repo usually predate the implementation in the server, so imho it's fine (although fix in the title becomes debatable then ... :))